-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for deserialization from JSON and XML #290
Conversation
Hi @madpah, first, thanks for your work on this python library, it really helped us in our first steps towards SBOM generation of some of the assets created in the AlmaLinux Build System, which is used to build the packages of the AlmaLinux OS distribution. As you can see here, I gave a try to this branch and although it already meets our expectations, and following @stevespringett's advice, I would like to mention that the bom-refs are missing after reusing an already existing SBOM. Is it maybe already in your radar and that you'll be fixing soon? Thanks and keep up the good work! |
@madpah Hey! 'sup? what's the plan on this? Fancy some help? |
Signed-off-by: Hakan Dilek <[email protected]>
Signed-off-by: Hakan Dilek <[email protected]>
If help is wanted, help could be provided ;) |
@keshav-space We would likely use this for aboutcode-org/scancode.io#583 ;) |
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
… `py-serializable` Signed-off-by: Paul Horton <[email protected]>
…nit tests passing :-) Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
…275_components` passed? Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
@javihernandez - thanks for your patience. If you are able to retest this branch again now - I believe we have the Dependency work complete now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed 9 / 136 files
- 📝 marked breaking changes and enhancements that need to be documented in the changelog
- ❓ had some questions that prevent me from approval
- ❌ had some things that require changes and fixes that prevent me from approval
… Plugin Signed-off-by: Paul Horton <[email protected]>
…y XML elements Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
…` making our models look odd Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Some notes on some parameters regarding shadowing.
Overall, I do not see any issues with your changes,
Signed-off-by: Paul Horton <[email protected]>
Signed-off-by: Paul Horton <[email protected]>
BREAKING CHANGE:
This development implements a (currently in Pre-Alpha) library developed specifically to address serialization and deserialization to/from JSON/XML and Pythonic Classes that utilise the
@property
decorator. See #185.Included in this PR:
py-serializable
to a stable stateAlso in this PR are the following PR's/Features:
Current known limitations:
>= 3.7
(see above)< 1.4
is now NOT supported - prior to1.4
- we have dropped support for the Vulnerabilities Schema Extension in this PR